Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing backspace key in hex color picker deletes the selected shape instead of hex code text #504

Closed
ptc-miduffy opened this issue Dec 16, 2020 · 1 comment
Labels

Comments

@ptc-miduffy
Copy link

Describe the bug
When editing the color of a shape, the color picker shows the hex code of the current color and the user is able to edit that text string to get the color they want. However, if the user presses the backspace key to delete part of the string, the shape is deleted instead.

To Reproduce
Steps to reproduce the behavior:

  1. Add a shape
  2. Click on Stroke to open color picker
  3. Click on hex code string to edit
  4. Press backspace key
  5. Notice shape is deleted and hex code string remains unchanged. Pressing the backspace key again edits the string as expected.

Expected behavior
Backspace key would delete characters in the hex code string, where the text cursor is located. Shape should not be deleted.

Screenshots
color-edit-delete-issue

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version: 87.0.4280.88

Additional context
This can be reproduced using the image editor on https://ui.toast.com/tui-image-editor

@lja1018
Copy link
Contributor

lja1018 commented Dec 23, 2020

@miduff
Thanks for the bug report. I will fix it as soon as possible.

@lja1018 lja1018 closed this as completed in 300007c Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants