Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] line endings #74

Closed
tarpdalton opened this issue Feb 19, 2020 · 1 comment
Closed

[Feature request] line endings #74

tarpdalton opened this issue Feb 19, 2020 · 1 comment

Comments

@tarpdalton
Copy link

Is your feature request related to a problem? Please describe.
Carriage return (CRLF) line endings cause problems on linux systems

Describe the solution you'd like
I want to see if there are any carriage returns (U+000D) in a file.
Adding it as a character in the config does not trigger gremlin tracker:

 "000D": {
   "zeroWidth": true,
    "description": "carriage return",
    "level": "error"
 }

Describe alternatives you've considered

  1. Render Line Endings vscode plugin is a solution where you can identify the line endings in files.

  2. You can edit .gitconfig to enforce certain line endings

#Set LF as your line ending default.
git config --global core.eol lf
#Set autocrlf to false to stop converting between windows style (CRLF) and Unix style (LF)
git config --global core.autocrlf false
  1. You can edit vscode settings to enforce line endings
"files.eol": "\n",

Additional context
I'm not sure if this is possible with the vscode api, but it would be helpful.
Are there other unicode characters that gremlin tracker can't detect?

@nhoizey
Copy link
Owner

nhoizey commented May 22, 2020

I indeed tried to add this character, but it isn't detected, or VS Code doesn't keep it "intact" on my macOS (guessing from microsoft/vscode#35797).

I don't know any other character this plugin can't detect, but there might be.

I will add the Render Line Endings plugin to the README, thanks for the information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants