Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription criteria wrong for multi-value criteria #48

Open
ahatherly opened this issue Dec 12, 2019 · 1 comment
Open

Subscription criteria wrong for multi-value criteria #48

ahatherly opened this issue Dec 12, 2019 · 1 comment

Comments

@ahatherly
Copy link
Contributor

I think the syntax currently used in the subscription criteria for NEMS may be incorrect. The criteria attribute is supposed to use the same syntax as standard FHIR searches. In a FHIR search if you want to search on a field and specify that the field should be one of two values, this is done using a comma separated list after the =. So, for example to search for events with either event type A or B you would use this syntax:
MessageHeader.event=A,B
However, the current spec says you should specify the criteria twice like this:
MessageHeader.event=A&MessageHeader.event=B
This would actually be treated as an AND in FHIR, meaning it would only match events with a code of both A and B (which is impossible)..
I realise this may actually have originally been my error, but I thought I should bring it to your attention in any case...

@james-answer
Copy link
Contributor

I agree this should be done as a comma separated list and currently does not logically make sense. I will add it to our list of things to look at changing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants