Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card links: border style #173

Open
davidhunter08 opened this issue Oct 17, 2024 · 4 comments
Open

Card links: border style #173

davidhunter08 opened this issue Oct 17, 2024 · 4 comments
Labels
component Add or improve a design component visual design

Comments

@davidhunter08
Copy link
Collaborator

davidhunter08 commented Oct 17, 2024

Description

The current colour contrast of the page background and card links surrounding border is 1.24:1. As it does not meet the non-text contrast ratio of 3:1 it makes the border somewhat redundant.

Screenshot 2024-10-17 at 10 54 25 Screenshot 2024-10-17 at 11 01 56

Blog post on non-text contrast of UI elements

https://iknowdavehouse.medium.com/why-debate-non-text-contrast-of-ui-elements-1be4313c9e12

Every time you design or build something, take 10 minutes to review it with all the parts of the interactive UI elements that do not meet 3:1 contrast ratio removed.

So if your button background does not meet 3:1 remove it, if your interactive card borders do not meet 3:1 remove them…

Then ask yourself:

  • Is the interface still understandable?
  • Is the interface still as usable?
  • Could I do more?
@davidhunter08
Copy link
Collaborator Author

#11 (comment)

@davidhunter08 davidhunter08 added component Add or improve a design component visual design and removed awaiting triage labels Oct 17, 2024
@davidhunter08
Copy link
Collaborator Author

Button v Card link comparison

Screenshot 2024-10-17 at 11 31 35

Something to consider is the visual alignment between buttons and card links (spacing, text size, border width etc).

Current sizes:

  • Secondary button border 2px v Card link border 1px
  • Button text size (mobile) 16px v Card link text size (mobile) 19px

Note: We're currently in the explorative stage of the secondary button and secondary card links.

Also the example above has the divider line connected to the right of the card link, but that still needs to be decided (see this issue).

@michaelgallagher
Copy link

michaelgallagher commented Oct 21, 2024

@davidhunter08 re: the above note "Something to consider is the visual alignment between buttons and card links (spacing, text size, border width etc).", i made a little doodle...

card-link-outline-test

the point here =

  • we have a proposal for a secondary button style with an outline that is 2px thick with round corners
  • cards are basically buttons
  • should button-y things be more visually aligned? (same type size, same vertical padding, same outline style, add a beard to card link sets)

@davidhunter08
Copy link
Collaborator Author

Some exploration of border styles, font sizes, spacing on card links:

card-link-border-style-exploration

Screenshots on Mural

cc @michaelgallagher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Add or improve a design component visual design
Projects
None yet
Development

No branches or pull requests

2 participants