Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Pull Request Workflow not checking files in subfolders of subfolders #1070

Open
paulstevendev opened this issue Nov 8, 2024 · 0 comments

Comments

@paulstevendev
Copy link

Bug Report

The linting that is performed in the pull request workflow pull-request.yml is only linting one file \packages\core\all.scss

Whilst the following syntax works locally in VS Code to lint files in the immediate subfolder of packages and also subfolders of subfolders, when it is run from the github workflow it only lints one file

"lint:css": "stylelint -f verbose --config ./tests/linters/.stylelintrc.js packages/**/*.scss",

What steps are required to reproduce the issue?

Create a pull request and then check the Actions tab

You can also see an example of a recent pull request here
https://github.com/nhsuk/nhsuk-frontend/actions/runs/11688315639/job/32548466347

  • expand the Run linting element

What was the environment where this issue occurred?

Github on Windows 10 PC

  • Device: PC
  • Operating System: Windows 10
  • Browser: Chrome
  • Browser version: Version 130.0.6723.117 (Official Build) (32-bit)
  • NHS.UK frontend package version: 9.1.0
  • Node version: 20.0.0

Is there anything else you think would be useful in recreating the issue?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant