Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Support for Double2dArray #1026

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Blahpapto1
Copy link

What does this Pull Request accomplish?

TODO: Include high-level description of the changes in this pull request.

Why should this Pull Request be merged?

TODO: Justify why this contribution should be part of the project.

What testing has been done?

TODO: Detail what testing has been done to ensure this submission meets requirements.

@Blahpapto1 Blahpapto1 changed the title Users/avgoel/add input support double2 d array Input Support for Double2dArray Nov 29, 2024
@Blahpapto1
Copy link
Author

Blahpapto1 commented Nov 29, 2024

For parsing Double2DArray value we are converting the default_value to string in _support.py. Also, handling repr(value) conversions in get_configuration_and_output_metadata_by_index method. This is one of the approach that we think is the best way to handle these conversions.

Another way, we can handle the parsing of Double2DArray value is to handle it after render_template method (before black._format_str method). This creates the output template then we fix all the instance in the generated output template through regex. But this happens during the _create_file method call, which may or may not be the best place to handle this case from a design perspective.

Copy link

Test Results

    40 files  ± 0      40 suites  ±0   54m 26s ⏱️ + 1m 43s
   703 tests + 3     703 ✅ + 3      0 💤 ±0  0 ❌ ±0 
17 090 runs  +90  16 020 ✅ +90  1 070 💤 ±0  0 ❌ ±0 

Results for commit 14c3349. ± Comparison against base commit c94bc0d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant