Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python as a default annotation under programming language. #599

Merged
merged 10 commits into from
Jan 30, 2024

Conversation

gpachecoNI
Copy link
Collaborator

@gpachecoNI gpachecoNI commented Jan 29, 2024

What does this Pull Request accomplish?

  • Adds new service Annotation ni/service.programminglanguage

Why should this Pull Request be merged?

AB#2625729

What testing has been done?

Run Tests

Copy link

github-actions bot commented Jan 29, 2024

Test Results

    30 files  ±0      30 suites  ±0   35m 38s ⏱️ +15s
   557 tests ±0     556 ✅ ±0      1 💤 ±0  0 ❌ ±0 
13 690 runs  ±0  12 620 ✅ ±0  1 070 💤 ±0  0 ❌ ±0 

Results for commit 0a62244. ± Comparison against base commit e028d5d.

♻️ This comment has been updated with latest results.

@gpachecoNI gpachecoNI force-pushed the users/gpacheco/AddMeasurmentLanguageAnnotation branch from 9195008 to 2ca085d Compare January 29, 2024 19:11
@gpachecoNI gpachecoNI requested a review from bkeryan January 29, 2024 19:31
@bkeryan
Copy link
Collaborator

bkeryan commented Jan 29, 2024

@gpachecoNI Please add Ariane as a reviewer.

@gpachecoNI gpachecoNI requested a review from achanyou January 29, 2024 19:37
@gpachecoNI gpachecoNI force-pushed the users/gpacheco/AddMeasurmentLanguageAnnotation branch from 68b8016 to c68ff7d Compare January 29, 2024 20:05
Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@gpachecoNI gpachecoNI requested a review from bkeryan January 30, 2024 16:38
@gpachecoNI gpachecoNI changed the title Add new annotation Add python as a default annotation under programming language. Jan 30, 2024
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion

Co-authored-by: Brad Keryan <brad.keryan@ni.com>
@gpachecoNI gpachecoNI merged commit 4f625db into main Jan 30, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/gpacheco/AddMeasurmentLanguageAnnotation branch January 30, 2024 21:03
@bkeryan bkeryan mentioned this pull request Aug 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants