Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In nidigital API, remove size argument from methods that take in an array #1070

Closed
sbethur opened this issue Oct 30, 2019 · 0 comments · Fixed by #1104
Closed

In nidigital API, remove size argument from methods that take in an array #1070

sbethur opened this issue Oct 30, 2019 · 0 comments · Fixed by #1104
Assignees
@sbethur
Labels
API nidigital source-breaker
Milestone
nidigital API upd...

Comments

@sbethur
Copy link
Contributor

sbethur commented Oct 30, 2019

  • Description of issue

In nidigital API, remove size argument from methods that take in an array. Size argument is redundant.

List of methods to update:

apply_tdr_offsets(self, num_offsets, offsets)
write_source_waveform_broadcast_u32(self, waveform_name, waveform_size, waveform_data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbethur sbethur

Labels
API nidigital source-breaker
Projects
None yet
Milestone
nidigital API updates and fixes
Development

Successfully merging a pull request may close this issue.

Bug1070/nidigital remove redundant size param ni/nimi-python
2 participants
@MrDuff8 @sbethur