Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping support for PyPy3 in nimi-python #1271

Closed
marcoskirsch opened this issue Feb 13, 2020 · 1 comment · Fixed by #1278
Closed

Consider dropping support for PyPy3 in nimi-python #1271

marcoskirsch opened this issue Feb 13, 2020 · 1 comment · Fixed by #1278
Labels

Comments

@marcoskirsch
Copy link
Member

Supporting PyPy officially is not trivial for us.

  • We aren't doing it correctly now nimi-bot log says "SKIPPED: InterpreterNotFound: pypy3" #1260
  • It doesn't support 64-bit Windows. This forces us to allow skipping environments in tox for system testing which means real problems could go on undetected (like a bad VM setup)
  • They are behind in Python language support, at 3.6 (CPython is at 3.8).
  • There is no pre-compiled numpy/scipy
    • So we need to either introduce a mechanism to skip those tests during system testing
    • Or we'd need to compile and install at execution time

Based on analysis of PyPI downloads I did back in October, out of 38,000 cumulative downloads of all NI Python modules there was a single (1!) download made from PyPy as the Python implementation:

2019-05-18 00:09:43 nidaqmx version 0.5.7 on Windows 7

So I propose we remove official support and stop spending efforts properly testing it and instead work on more valuable things.

Customer feedback will be taken very seriously here.

@marcoskirsch
Copy link
Member Author

Update: We have a approval to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant