Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter name "time_set" to "time_set_name" in applicable nidigital methods #1396

Closed
sbethur opened this issue Apr 9, 2020 · 0 comments · Fixed by #1398
Closed

Comments

@sbethur
Copy link
Contributor

sbethur commented Apr 9, 2020

Description of issue

In methods like:

def configure_time_set_compare_edges_strobe(self, time_set, strobe_edge):

time_set parameter refers to the time set name and not time set, which in nidigital paradigm refers to an object comprising of name, timing edge values, 2x setting etc.

Parameter name should be changed in internal metadata so that it gets propagated to all APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant