Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No test coverage for verifying installers pull in dependencies correctly #1446

Open
sbethur opened this issue Apr 30, 2020 · 1 comment
Open

No test coverage for verifying installers pull in dependencies correctly #1446

sbethur opened this issue Apr 30, 2020 · 1 comment
Labels
test

Comments

@sbethur
Copy link
Contributor

sbethur commented Apr 30, 2020

Description of issue

Unit tests run against source files of the module in generated folder. System tests are run by building a sdist, which doesn't install the dependencies. This means we don't have test coverage for verifying that the installers pull in dependencies like nitclk, hightime, etc. correctly.
@sbethur sbethur added the test label Apr 30, 2020
@ni-jfitzger
Copy link
Collaborator

ni-jfitzger commented Apr 30, 2020 •
edited
Loading

It looks like tox-wheel is the way to do this. It's an external plugin.

It was decided to implement support externally, before trying to add the functionality to tox core.
See tox-dev/tox#850

@sbethur sbethur mentioned this issue Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ni-jfitzger @sbethur