Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_channel_name() should be deprecated and replaced by get_channel_names() in nidcpower #1588

Closed
luisgomes252 opened this issue Apr 14, 2021 · 0 comments · Fixed by #1578
Closed

get_channel_name() should be deprecated and replaced by get_channel_names() in nidcpower #1588

luisgomes252 opened this issue Apr 14, 2021 · 0 comments · Fixed by #1578
Milestone
nidcpower support...

Comments

@luisgomes252
Copy link
Contributor

luisgomes252 commented Apr 14, 2021 •
edited
Loading

Description of issue

nidcpower bindings contain get_channel_name(index) method whose input is a single 1-based channel index. Being 1-based conflicts with the GetChannelNameFromString(), which is 0-based.

As per the decision here:

  • get_channel_name(index) should be deprecated in nidcpower.
  • Add get_channel_names(indices)
    • Since GetChannelNameFromString() is already present in the C API, the implementation in Python can be based on the C entry point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
nidcpower support for Independent Cha...
Development

Successfully merging a pull request may close this issue.

US1198694: add nidcpower.Session.get_channel_names() luisgomes252/nimi-python
2 participants
@sbethur @luisgomes252