Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERIOD value types #74

Closed
9 tasks
niccokunzmann opened this issue Jan 10, 2022 · 2 comments
Closed
9 tasks

PERIOD value types #74

niccokunzmann opened this issue Jan 10, 2022 · 2 comments
Labels
bug Something isn't working polar question Further information is requested

Comments

@niccokunzmann
Copy link
Owner

niccokunzmann commented Jan 10, 2022

Describe the bug

The ICS standard suggests the period type can be used for

  • DTSTART
  • RDATE
  • more?

RFC 5545, pages 36, 120

HELP!

I need at last one ICS file first before I an test that particular type of data.

Also, please comment:
It seems rare that a PERIOD is encountered. People using this module will most likely not test for that rare instance.
My suggestion is because of that,

  • that the DTSTART and the DTEND both have a datetime/date as a value and not a PERIOD type
  • AND/OR that we provide test data for other people so that they can test for these rare cases.

What do you think?

Suggested implementation

  • add an ICS file
  • add a test
  • implement the test
  • fix the test

We're using [Polar.sh](https://polar.sh/niccokunzmann) so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work. Fund with Polar
@niccokunzmann niccokunzmann added bug Something isn't working help wanted Extra attention is needed question Further information is requested labels Jan 10, 2022
@niccokunzmann
Copy link
Owner Author

niccokunzmann commented Oct 13, 2022

See also:

@niccokunzmann niccokunzmann removed the help wanted Extra attention is needed label Nov 3, 2022
@niccokunzmann
Copy link
Owner Author

#114 #113 yield the case of RDATE being a PERIOD.

The default value type is DATE-TIME. The time value MUST be one of the forms defined for the DATE-TIME value type. The value type can be set to a DATE value type.

This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working polar question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant