Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New panel variants #161

Closed
wa-rren-dev opened this issue Mar 5, 2021 · 2 comments · Fixed by #172
Closed

New panel variants #161

wa-rren-dev opened this issue Mar 5, 2021 · 2 comments · Fixed by #172
Labels
IN JIRA Any issues that have been raised on the Design System Jira board

Comments

@wa-rren-dev
Copy link
Contributor

wa-rren-dev commented Mar 5, 2021 •
edited
Loading

Create new panel variants as discussed here #160

.panel--inverse

image

.panel--impact-alt

image
@wa-rren-dev wa-rren-dev added the IN JIRA Any issues that have been raised on the Design System Jira board label Mar 5, 2021
@wa-rren-dev
Copy link
Contributor Author

@gaynorc Sure no prob holding off, I'm only pushing for this to get the homepage stuff in place. There's only two variants we're suggesting adding now (the ones above) - could you stick any feedback to them / requests for additions on this issue? We're going to keep issues for how we do stuff, and the discussions for whether we do it at all!

@wa-rren-dev
Copy link
Contributor Author

wa-rren-dev commented Mar 17, 2021 •
edited
Loading

This is being implemented in #172. Any further variations we can discuss separately.

@ediblecode ediblecode mentioned this issue Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IN JIRA Any issues that have been raised on the Design System Jira board
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NDS-143 New panel variants - inverse & impact-alt nice-digital/nice-design-system
1 participant
@wa-rren-dev