Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action banner closeable not working #296

Open
TrishB70 opened this issue Dec 6, 2022 · 1 comment
Open

Action banner closeable not working #296

TrishB70 opened this issue Dec 6, 2022 · 1 comment

Comments

@TrishB70
Copy link

TrishB70 commented Dec 6, 2022

We now only have 2 variants of the action banner in the nds. Default and subtle. Have we ditched closable? I noticed it wasn't working when I went to put one on a page.

@rnickr
Copy link

rnickr commented Dec 8, 2022

We did discuss removing it when we were looking at the Action banner documentation - it was discussed as part of the docs work and in the Design System Stand-up Teams chat. We were struggling to explain a use case for it and nobody could find one in use. The decision was to remove until there was a provable use case.

However, at the minute it's still in the Design System as the devs haven't got round to taking it out: https://design-system.nice.org.uk/storybook/?path=/story/components-action-banner--closeable

So it should still work, if not it might be an issue with the implementation.

Could you look at adding in the info on the docs page to explain the use case? https://nicedigital.atlassian.net/wiki/spaces/NDS/pages/3267919879/Action+banner+-+component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants