Not retrying the command

[geoffreyIOOF]

Describe the bug
HI,
here is my test snippet

- name: Build with Maven
  uses: nick-invision/retry@v2.4.0
  with:
    timeout_seconds: 60
    max_attempts: 3
    retry_wait_seconds: 20
    retry_on: timeout
    command: mvn -Dmaven.wealthcentral.full.build=true clean install site

I tried timeout_seconds=60 timeout_minutes=1, still not working . I tried retry_on: error and it restarted the command, but I only wants to restart the command on timeout. Am I doing something wrong, or misunderstand the retry_on: timeout function ?

Expected behavior
I would expect the command to restart "mvn -Dmaven.wealthcentral.full.build=true clean install site". but I only get the error and the step fails.

Screenshots

Logs
https://pipelines.actions.githubusercontent.com/VZK7aeekU2uaNe4Ic693P6kodHwzQMznZWFFtaEw4BXgNmLWia/_apis/pipelines/1/runs/4111/signedlogcontent/3?urlExpires=2021-07-23T02%3A43%3A50.6523982Z&urlSigningMethod=HMACV1&urlSignature=q0FhuLAf1914%2FeQ%2FEOZJHeYaabiI5OlstxPwr3RiUvY%3D

[nick-invision]

The logs link doesn't work for me. Can you download and attach the logs?

[geoffreyIOOF]

retry_logs.txt
Thanks for having a look

[AraHaan]

I wonder if we can specify timeout+error in retry_on for those who want it to retry on both.

[addshore]

This sounds similar to what I am seeing...

I am using as follows:

      - name: Run Tests - ${{ matrix.suite }}
        uses: nick-fields/retry@v2
        timeout-minutes: 33 # 3 attempts at 10+1 mins max each
        env:
          DATABASE_IMAGE_NAME: ${{ matrix.databaseImageName }}
        with:
          # This step should only take ~5 mins at most to complete, but sometimes locks up
          timeout_minutes: 10
          max_attempts: 3
          retry_on: timeout
          command: make test SUITE=${{ matrix.suite }}

And there is the log output, with only a single timeout indicated, and no retires occouring

Thu, 24 Nov 2022 17:21:43 GMT Run nick-fields/retry@v[2](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:2)
Thu, 24 Nov 2022 17:21:43 GMT   with:
Thu, 24 Nov 2022 17:21:4[3](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:3) GMT
    timeout_minutes: 10
Thu, 24 Nov 2022 17:21:43 GMT     max_attempts: 3
Thu, 2[4](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:4) Nov 2022 17:21:43 GMT
    retry_on: timeout
Thu, 24 Nov 2022 17:21:43 GMT     command: make test SUITE=repo
Thu, 24 Nov 2022 17:21:43 GMT     retry_wait_seconds: 10
Thu, 24 Nov 2022 17:21:43 GMT     polling_interval_seconds: 1
Thu, 24 Nov 2022 1[7](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:7):21:43 GMT
    warning_on_retry: true
Thu, 24 Nov 2022 17:21:43 GMT     continue_on_error: false
Thu, 24 Nov 2022 17:21:43 GMT   env:
Thu, 24 Nov 2022 17:21:43 GMT     env_file: versions/wmde[9](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:9).env
Thu, 24 Nov 2022 17:21:43 GMT     DATABASE_IMAGE_NAME: mariadb:[10](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:10).9
Thu, 24 Nov 2022 17:21:43 GMT cd test && bash test_stop.sh ""
Thu, 24 Nov 2022 17:21:44 GMT No containers to terminate.
Thu, 24 Nov 2022 17:21:44 GMT bash test/test_suite.sh repo
Thu, 24 Nov 2022 [17](https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853#step:4:18):21:44 GMT
#########################################
Thu, 24 Nov 2022 17:21:44 GMT #########################################
Thu, 24 Nov 2022 17:21:44 GMT ####         Start testing! 🤞       ####

...snip...

Thu, 24 Nov 2022 17:25:06 GMT [0-1] RUNNING in chrome - /specs/repo/property.js
Thu, 24 Nov 2022 17:31:44 GMT make: *** wait: No child processes.  Stop.
Thu, 24 Nov 2022 17:31:44 GMT make: *** Waiting for unfinished jobs....
Thu, 24 Nov 2022 17:31:44 GMT make: *** wait: No child processes.  Stop.
Thu, 24 Nov 2022 17:31:44 GMT 1
Thu, 24 Nov 2022 17:31:54 GMT Error: Timeout of 600000ms hit

This is from https://github.com/wmde/wikibase-release-pipeline/actions/runs/3488327445/jobs/5948299853

[addshore]

And I can confirm that the change proposed in #106 seems to fix this issue for me
Tested in https://github.com/wmde/wikibase-release-pipeline/actions/runs/3800803545/jobs/6465662773
as I see it go through various attempts

Warning: Attempt 1 failed. Reason: Timeout of 600000ms hit

[nick-fields]

Thanks for testing that PR. I'll get it pulled into a release shortly

[github-actions]

🎉 This issue has been resolved in version 2.8.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[addshore]

Amazing, thanks!