Skip to content
This repository has been archived by the owner on Jul 13, 2024. It is now read-only.

TypeScript 3.5 errors #297

Closed
haizz opened this issue May 31, 2019 · 2 comments · Fixed by #298
Closed

TypeScript 3.5 errors #297

haizz opened this issue May 31, 2019 · 2 comments · Fixed by #298
Labels
🐛 Bug Unexpected behavior to be fixed

Comments

@haizz
Copy link
Contributor

haizz commented May 31, 2019

TypeScript 3.5 had a breaking change: microsoft/TypeScript#30637
Because of this there are errors:

.../node_modules/@gitgraph/core/src/graph-rows/regular.ts

Error:(44, 3) TS2322: Type 'unknown[]' is not assignable to type 'T[]'.
  Type 'unknown' is not assignable to type 'T'.
    'unknown' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constraint '{}'.
.../node_modules/@gitgraph/core/src/graph-rows/regular.ts

Error:(258, 40) TS2345: Argument of type 'unknown' is not assignable to parameter of type 'string'.
@haizz haizz added the 🐛 Bug Unexpected behavior to be fixed label May 31, 2019
@nicoespeon
Copy link
Owner

Thanks for spotting @haizz 👍

We upgraded our version of TS to the latest and fixed the issue. Will publish a new version soon with these fixes.

@nicoespeon
Copy link
Owner

nicoespeon commented Jun 7, 2019

Version v1.3.0 of @gitgraph/js and v1.4.0 of @gitgraph/react include this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 Bug Unexpected behavior to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants