Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit DefaultPickingPlugins dependency #44

Open
musjj opened this issue Apr 7, 2024 · 0 comments
Open

Implicit DefaultPickingPlugins dependency #44

musjj opened this issue Apr 7, 2024 · 0 comments

Comments

@musjj
Copy link

musjj commented Apr 7, 2024

#[cfg(feature = "pointer_focus")]
app.add_plugins(DefaultPickingPlugins)
.add_systems(PostUpdate, enable_click_request);

Right now this plugin automatically inserts DefaultPickingPlugins, but this will cause a conflict if the user wants to control the insertion of the plugin.

For example, I have customized DefaultPickingPlugins like this:

DefaultPickingPlugins
    .build()
    .disable::<BevyUiBackend>()
    .add(MyOwnUiBackend)

A user might also prefer to manually insert the picking plugins:

picking_core::CorePlugin,
picking_core::InteractionPlugin,
input::InputPlugin,
bevy_picking_raycast::RaycastBackend,

This will prevent this plugin from functioning in this kind of workflows. Maybe an implicit dependency is better in this case? Not so sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant