-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFSKOPE_VERSION and version comparison #61
Comments
hexabits
referenced
this issue
in hexabits/nifskope
Jun 7, 2014
#61 Class for treating app version strings as comparable objects, to help with migration code. Also for formatting the version string with various levels of detail for display purposes (e.g. application window title)
hexabits
referenced
this issue
in hexabits/nifskope
Jun 7, 2014
hexabits
referenced
this issue
in hexabits/nifskope
Jun 7, 2014
#61, #11 A `config.h` file was unnecessary as the default QSettings constructor takes into account the values set in `setOrganizationName` and `setApplicationName` in the main() function. Thus, removed the use of the macro. Reorganized multiple settings. Renamed, fixed typos, consistent capitalization.
hexabits
referenced
this issue
in hexabits/nifskope
Jun 7, 2014
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the entire version string is compared with the version stored in the registry each time NifSkope is opened. This is done in
NifSkope::migrateSettings()
in order to clear stored settings when moving between versions. This was changed from having separate settings per version. (See #11) I have updated the ticket there with more recent developmentsGoing from 1.2.0a1.dev19 to 1.2.0a1.dev20, for example, will cause the UI to reset. This is annoying for testers. As I elaborated in #11 this is also completely unnecessary as it is only changes in Qt versions that need this reset.
The entire version string being the only thing available for comparison is definitely not ideal. Instead, the version string should be parsed and turned into an object which can be used for comparison, with configurable granularity.
For example:
As you can see, ver5 and ver4 are the same except for their granularity.
It would also be useful for displaying the version in a more human friendly way. A display version would be nice for the window title for example. (It currently says only "NifSkope")
Related
#11 Revert change which did separate registry settings per version
#12 Add a "Restore Defaults" function which clears stored settings
The text was updated successfully, but these errors were encountered: