Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILS direction #225

Open
mric3412 opened this issue May 7, 2018 · 6 comments
Open

ILS direction #225

mric3412 opened this issue May 7, 2018 · 6 comments

Comments

@mric3412
Copy link

mric3412 commented May 7, 2018

ILS for plane is not working when you want to land in the same direction than for takeoff
Planes generaly takes off and lands in the same direction (case of constant wind's direction)
An ILS working in all approach's direction would be a good option in most cases.
VERSIONS : v943 / v942 (older versions not tested)
BOARD TYPE : Minim OSD V1.1 (ATMEGA328 and MAX7456)

@night-ghost
Copy link
Owner

required files?

@mric3412
Copy link
Author

mric3412 commented May 8, 2018

It can be tested with the following tlog file
log.zip
Select only the ILS option of the HUD panel to clearly observe the ILS behavior : very hard (impossible?) to get the pair of horizontal and vertical lines (arrows suggesting to take another direction are very rarely absent)

@mric3412
Copy link
Author

I modified showILS() in Panels.h (ILS far less accurate is more useful in my case)
I regressed the code to v936 concerning grad_to_sect() (just trying to fix radar and arrow_home_direction issues)
These modifications are attached in the following zip file (with a new charset 2.4.1.5.1 : minor mods of 2.4.1.5 for radar, rssi, sat, TOTal dist icons etc.)
It's just for tests (I didn't have the time to test it on the field : .hex for Mavlink is in dir buided_bin/, new charset is in dir charset/, ADSB is desactivated)
v943_fusion936.zip

@night-ghost
Copy link
Owner

waiting for your PR

@mric3412
Copy link
Author

I tested in flight ILS (for plane) with softer angle constraints to display more easily horizontal and vertical lines of ILS (without softer constraints, these lines were too rarely displayed to be tested). Now it seems to me that ILS disfunctions.
For example, look at the current version of Panels.h (line 305) : if the plane is aligned with the runway, we want vertical lines at the middle of HUD <=> lineposition=totalNumberVertLines/2 <=> currentAngleDisplacement=0. But, because of line 309, 0degres will become -180degres.
In v857, Panels.h@286 currentAngleDisplacement==0 => linePosition==(totalNumberOfLines/2). So it seems OK until v857 but it seem's to me that giving the possibility to use ILS in opposite direction introduced a bug.

@night-ghost
Copy link
Owner

Thanks, will see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants