Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libre not uploading new SAGE to nightscout #108

Closed
kylmcw opened this issue Apr 14, 2024 · 4 comments
Closed

Libre not uploading new SAGE to nightscout #108

kylmcw opened this issue Apr 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@kylmcw
Copy link
Contributor

kylmcw commented Apr 14, 2024

Freestyle Libre SAGE is not uploading to nightscout at all.

@kylmcw kylmcw added the bug Something isn't working label Apr 14, 2024
@bjornoleh
Copy link
Contributor

SAGE upload to NS was introduced in iAPS here:
Artificial-Pancreas/iAPS@2d60ffc#diff-d6569af4c16ca2e28f1ea9edccf5b7693c1b4b61935bdb870c106567ecb04d63

This includes changes to two files in the Dependencies directory which are deleted from the submodule based OiAPS (alpha):

Dependencies/LibreTransmitter/Sources/LibreTransmitter/LibreSensor/SensorContents/SensorData.swift
Dependencies/LibreTransmitter/Sources/LibreTransmitter/LibreTransmitterManager.swift

To make SAGE uploads happen in submodule based OiAPS, we would probably need to fit this in elsewhere, or make the required PR to https://github.com/LoopKit/LibreTransmitter.

I don't know if SAGE upload was implemented already in Loop? I think not, although it has been discussed previously. @marionbarker would probably know.

@avouspierre
Copy link
Contributor

To review in alpha

@avouspierre avouspierre added this to Trio Apr 15, 2024
@avouspierre avouspierre moved this to In review in Trio Apr 15, 2024
@kylmcw
Copy link
Contributor Author

kylmcw commented Apr 16, 2024

SAGE verified uploaded to Nighscout on Alpha branch.

image

@bjornoleh
Copy link
Contributor

Fixed in #112

@github-project-automation github-project-automation bot moved this from In review to Done in Trio Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants