Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GitHub build instructions in testflight.md needs updating for Trio app identifier names etc #294

Closed
bjornoleh opened this issue Jun 10, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation needs-triage

Comments

@bjornoleh
Copy link
Contributor

Describe the bug

The current GitHub build instructions in testflight.md needs updating for Trio app identifier names etc to reflect the actual names and what it currently looks like in the Apple Developer portal.

There is a mismatch between the following section and the screenshots below:
https://github.com/bjornoleh/Trio/blob/trio-bo/fastlane/testflight.md#add-app-group-to-bundle-identifiers

Add App Group to Bundle Identifiers

  1. Go to Certificates, Identifiers & Profiles on the Apple developer site.
  2. For each of the following identifier names:
    * FreeAPS
    * FreeAPS watchkitapp
    * FreeAPS watchkitapp watchkitextension

image

image

Additional context

I had previously built the app with Xcode, my screenshots probably differ from a GitHub actions only builder, as I believe the XC prefix indicates Xcode generated identifiers.

Hopefully someone can supplement with relevant screnshots.

Trio Version:

  • Repo: nightscout/trio
  • Git Reference: 32b5e95
@bjornoleh bjornoleh added bug Something isn't working documentation Improvements or additions to documentation needs-triage labels Jun 10, 2024
@bjornoleh bjornoleh added this to Trio Jun 10, 2024
@bjornoleh
Copy link
Contributor Author

Tagging @marionbarker for her expertise in this area.

Also noting that the instructions in https://docs.diy-trio.org/en/latest/operate/build.html#build-trio-with-github appear to be accurate:

Identifier Names will be: FreeAPS, FreeAPSWatch, FreeAPSWatch WatchKit Extension, LiveActivityExtension

These names are the same as that used by iAPS, they are distinguised by the Identifier itself, which include the new BundleID for your Trio app

If you build with Xcode before, they will start with XC and use the Identifier string rather than the Name

Identifiers will be:

org.nightscout.TEAMID.trio

org.nightscout.TEAMID.trio.watchkitapp

org.nightscout.TEAMID.trio.watchkitapp.watchkitextension

org.nightscout.TEAMID.trio.LiveActivity

Only the first 3 of these identifiers need to have the App Group added

For the list below, make sure the box next to App Group is checked, and click Configure to select the same app group as Loop: group.com.TEAMID.loopkit.LoopGroup

You must add this App Group to each of the following identifiers:

org.nightscout.TEAMID.trio

org.nightscout.TEAMID.trio.watchkitapp

org.nightscout.TEAMID.trio.watchkitapp.watchkitextension

In App Store Connect, the Bundle ID for Trio will be: org.nightscout.TEAMID.trio

@marionbarker
Copy link
Contributor

I closed this because #297 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation needs-triage
Projects
Status: Done
Development

No branches or pull requests

2 participants