Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boluses deleted from History screen reappear after next bolus (MDT 754 pump) #399

Open
dsut4392 opened this issue Aug 29, 2024 · 6 comments
Labels
bug Something isn't working dependencies Pull requests that update a dependency file known issue Known issue with Trio or its submodules; possible duplicate long-term For later, doesn't get staled

Comments

@dsut4392
Copy link

Describe the bug

If you delete a bolus from the history screen, the deleted bolus reappears in the history the next time you issue a bolus.

Attach a Log

Tap the Trio settings icon at the bottom of the screen, then tap 'Share logs' on the bottom of the list and attach it to this ticket.

To Reproduce

  1. issue a bolus, manual or SMB
  2. open History screen and swipe left on the bolus to delete it.
  3. return to the main screen and confirm the bolus is no longer shown
  4. issue a new bolus, and the previously deleted bolus reappears both on the main screen and the history screen

Expected behaviour

Once you delete a bolus from the history it should stay deleted. Deleting a bolus from the history may be necessary if your cannula has leaked, or if you have forgotten to suspend while your pump was disconnected.

Screenshots

video attached

Setup Information (please complete the following information):

Smartphone:

  • Hardware: iPhone 15 Pro Max
  • OS Version: [e.g. iOS 17.5]

Pump:

  • Manufacturer: OrangeLink, MDT 754
  • Model: [e.g. Omnipod Dash or Eros]

CGM:

  • Device: Nightscout
  • Manager app: [e.g. Dexcom App or xDrip4iOS]

Trio Version:

  • Version Number: 0.2.0 main
  • Repo: nightscout/trio
  • Git Reference: 6433d94
@dsut4392 dsut4392 added bug Something isn't working needs-triage labels Aug 29, 2024
@Sjoerd-Bo3 Sjoerd-Bo3 added this to Trio Aug 29, 2024
@dsut4392
Copy link
Author

log_prev.txt
log.txt

@dsut4392
Copy link
Author

RPReplay_Final1724935161.mp4

@dsut4392
Copy link
Author

Note that in the video above, the 0.6U bolus reappeared, but the 0.18U bolus did not.

@MikePlante1
Copy link
Contributor

MikePlante1 commented Aug 29, 2024

I just reproduced the same thing with my 722 on Trio (TCD). Bolused 0.1 U, deleted from Trio, after next Loop cycle the 0.1 U bolus returned)

@dnzxy
Copy link
Contributor

dnzxy commented Aug 29, 2024

This is a known LoopKit issue.

@marionbarker has raised it, I have raised it as well in 2023, when I implemented the swipe-to-delete feature for iAPS that is also found in Trio.

It has to the with the event store of the boluses, it is cleared upon running a new cycle. So if you were to bolus 3 times, then delete those boluses, then bolus a 4th time, all within one cycle, all 4 entries will reappear, because they are send to Trio / iAPS / Loop by the device layer event store when the apps perform the storing of pump events to pump history. That is why the 0.18 U bolus did not reappear, but the 0.6 U bolus that was given at the beginning of the recording reappears.

We cannot address this in Trio, it needs addressing in LoopKit. Given, that this has not been addressed in ~10 months since finding the issue, I doubt it will ever be addressed.

@dnzxy
Copy link
Contributor

dnzxy commented Aug 29, 2024

I just reproduced the same thing with my 722 on Trio (TCD). Bolused 0.1 U, deleted from Trio, after next Loop cycle the 0.1 U bolus returned)

Same issue, see previous comment. TCD or non-TCD does not matter here. You can also reproduce this for Loop and for iAPS. A fresh cycle will clear the event store.

@dnzxy dnzxy added dependencies Pull requests that update a dependency file long-term For later, doesn't get staled known issue Known issue with Trio or its submodules; possible duplicate and removed needs-triage labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file known issue Known issue with Trio or its submodules; possible duplicate long-term For later, doesn't get staled
Projects
Status: No status
Development

No branches or pull requests

3 participants