Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update(issue templates): More readable styling and expansion of questions #202

Merged
merged 10 commits into from
May 30, 2024
Merged

Update(issue templates): More readable styling and expansion of questions #202

merged 10 commits into from
May 30, 2024

Conversation

Sjoerd-Bo3
Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 commented May 16, 2024 •
edited
Loading

To make the Issues clearer to read

Before (Feature Request):

image

After (Feature Request):

CleanShot 2024-05-30 at 22 49 05@2x

Before (Bug):

image

After (Bug):

CleanShot 2024-05-30 at 22 48 11@2x

@Sjoerd-Bo3
feat(issue templates): Update with different styling
3899adf 
To make the Issues clearer to read
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Sjoerd-Bo3 Sjoerd-Bo3 self-assigned this May 16, 2024
@Sjoerd-Bo3 Sjoerd-Bo3 added the documentation Improvements or additions to documentation label May 16, 2024
@Sjoerd-Bo3
Copy link
Contributor Author

@bjornoleh @marionbarker @dnzxy Plz review

@Sjoerd-Bo3 Sjoerd-Bo3 changed the title Update(issue templates): Different more readable styling Update(issue templates): More readable styling and expansion of questions May 27, 2024
@Sjoerd-Bo3
Copy link
Contributor Author

Yes the FP was allowed, because mister @bjornoleh did a push to my repo (by mistake)

bjornoleh
bjornoleh previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested the bug and feature request templates in my own fork, and the labels were successfully applied automatically. I could however not get the project assigned automatically. Possibly there is some issue with the templates, or perhaps in my testing. But unless someone can spot the issue immediately, I’m still open for merging this as is. Then we’ll see if it works or not.

dnzxy
dnzxy requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in my personal form. Looks great generally, minor comments. The Discord invite link that you see when you tap Issues and can select to either open a bug, a feature or go to Discord is expired.

.github/ISSUE_TEMPLATE/feature-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.md Outdated Show resolved Hide resolved
@Sjoerd-Bo3
Copy link
Contributor Author

Sjoerd-Bo3 commented May 30, 2024 •
edited
Loading

Tested this in my personal form. Looks great generally, minor comments. The Discord invite link that you see when you tap Issues and can select to either open a bug, a feature or go to Discord is expired.

Fixed all the points!

@dnzxy dnzxy self-requested a review May 30, 2024 20:46
@Sjoerd-Bo3 Sjoerd-Bo3 requested review from aug0211 and removed request for aug0211 May 30, 2024 21:18
@bjornoleh bjornoleh merged commit fd5ff68 into nightscout:dev May 30, 2024
1 check passed
@dnzxy dnzxy mentioned this pull request May 31, 2024
Closed
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Jun 1, 2024
@bjornoleh @mountrcg
Merge pull request nightscout#202 from Sjoerd-Bo3/feat/issue-templates
3249365 
Update(issue templates): More readable styling and expansion of questions
This was referenced Jun 10, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornoleh bjornoleh bjornoleh approved these changes

@dnzxy dnzxy dnzxy approved these changes

@aug0211 aug0211 aug0211 approved these changes

@MikePlante1 MikePlante1 Awaiting requested review from MikePlante1 MikePlante1 is a code owner

@marionbarker marionbarker Awaiting requested review from marionbarker

@t1dude t1dude Awaiting requested review from t1dude t1dude is a code owner

Assignees

@Sjoerd-Bo3 Sjoerd-Bo3

Labels
documentation Improvements or additions to documentation
Projects
Trio
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sjoerd-Bo3 @aug0211 @dnzxy @bjornoleh