speech plugin is always enabled on dev

[PieterGit]

Without adding speech to ENABLE I get speech messages with current dev.

I think it's caused by these lines:

cgm-remote-monitor/lib/client/index.js

Line 600 in 43e9301

var speechPlugin = client.plugins('speech');

I think the server settings must be checked whether the speech plugin is enabled.

[PieterGit]

temporary fix added to dev. this will disable the complete plugin until @sulkaharo has the time to add the proper code to only execute it when the plugin is enabled.

[sulkaharo]

Did it speak out even if you checked off the box in the client settings?

[PieterGit]

@sulkaharo we didn't add speech to the ENABLE var and then it would speak it out on page load.
If I selected a Dutch anguage it spoke the English text with a dutch accent.
I could find a check box in the client settings (hamburger menu), even if I enable the speech plugin.
Are you sure you committed/pushed all the changes? 😄

[jaylagorio]

Can you also make this observe the ?mute=true URL parameter so if that's set it doesn't talk?

[PieterGit]

@sulkaharo fixed this with d80c605
@jaylagorio could you add add separate feature request for the ?mute=true URL parameter? This issue was about the fact that it played stuff even, when you didn't have the plugin enabled.

Closing this issue because it's fixed.