Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with disabling SMB logic and logging issues #18

Closed
JeremyStorring opened this issue Apr 13, 2024 · 2 comments
Closed

Fix issue with disabling SMB logic and logging issues #18

JeremyStorring opened this issue Apr 13, 2024 · 2 comments

Comments

@JeremyStorring
Copy link
Contributor

Describe the bug
SMB logic was switched in determine-basal. The logic should be modified slightly. There is also an issue with logging.

The variable names are misleading for SMBs, if smbIsOff == True there are no SMBs as long as smbIsAlwaysOff == False.

If smbIsOff == True and smbIsAlwaysOff == True, that means there is a schedule in which they will be disabled (i.e., 10 PM to 6 AM).

The logic should be adjusted such that:
if smbIsOff == True and smbIsAlwaysOff == False - disable SMBs
if smbIsOff == True and smbIsAlwaysOff == True - there is an SMB Schedule to follow

Additional context
Discord messaging between Jeremy & Mike

@bjornoleh
Copy link
Contributor

This should be fixed by #20 and OiAPS PR 120. Can we close this?

@JeremyStorring
Copy link
Contributor Author

Closed due to above comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants