You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
SMB logic was switched in determine-basal. The logic should be modified slightly. There is also an issue with logging.
The variable names are misleading for SMBs, if smbIsOff == True there are no SMBs as long as smbIsAlwaysOff == False.
If smbIsOff == True and smbIsAlwaysOff == True, that means there is a schedule in which they will be disabled (i.e., 10 PM to 6 AM).
The logic should be adjusted such that:
if smbIsOff == True and smbIsAlwaysOff == False - disable SMBs
if smbIsOff == True and smbIsAlwaysOff == True - there is an SMB Schedule to follow
Additional context
Discord messaging between Jeremy & Mike
The text was updated successfully, but these errors were encountered:
Describe the bug
SMB logic was switched in determine-basal. The logic should be modified slightly. There is also an issue with logging.
The variable names are misleading for SMBs, if smbIsOff == True there are no SMBs as long as smbIsAlwaysOff == False.
If smbIsOff == True and smbIsAlwaysOff == True, that means there is a schedule in which they will be disabled (i.e., 10 PM to 6 AM).
The logic should be adjusted such that:
if smbIsOff == True and smbIsAlwaysOff == False - disable SMBs
if smbIsOff == True and smbIsAlwaysOff == True - there is an SMB Schedule to follow
Additional context
Discord messaging between Jeremy & Mike
The text was updated successfully, but these errors were encountered: