Fixed an issue with SMB logic. #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leading, so comments have been added. An issue with console logging has been addressed as well.
|
@JeremyStorring I proposed in #20 a fix to be done in iAPS. The second part of this PR would still make sense and re-ensure the part where I suggested that in OiAPS if someone toggles smbIsOff to true then smbIs AlwaysOff should be set to false. |
but of course vice-versa as I think the variable naming is "off" in OiAPS not in oiref. |
|
Closing this in favour of #20, which has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.