-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --standalone
flag in the tool.
#18
Comments
@garg3133
If yes, then will the right approach be to add
I also wanted to confirm the required dependencies for this. So far I assume the dependencies |
Yes.
No. I'm not talking about an NPM script command but the commands that are implemented in the tool itself. Run So, in this issue, we want to add support for a I'd suggest you to first try running the tool yourself and play around with it, everything will be more clear to you then. |
@garg3133 Minimist is used for parsing CLI arguments so we have to add
We also need to add
We can handle the downloading logic with conditional statements in
|
@itsspriyansh You're going in the right direction.
Yes, although you need to re-write the whole download logic, you just need to modify the code based on what we want and don't want to download in the standalone mode. |
@garg3133 I have gone through Android setup script and its related function. I have some doubts regarding this. However I am not sure about Android Debug Bridge, since it is important for communicating with emulator but I am not sure if it is strictly required only for setting up the emulator. Apart from this I do not see anything specific in the android setup script that is downloading anything extra related to Nightwatch and testing. Please let me know whatever I am missing out. |
@itsspriyansh ADB is also necessary otherwise while you'd have an Emulator setup up, you won't be able to do much with it (like install new app, etc.). Setting up browser can be optional in What'd be helpful here is if you can document all the cases with which the tool is run and what are all the tools/binaries are downloaded/installed in each case and in what order. Like just go through code and keep documenting that if we have these conditions, then first this will be installed, then this will be checked and installed, etc. Such a document will greatly help in understanding the codebase without going back and forth in the file all the time. |
@garg3133 I had raised PR. Please let me know if the changes are correct. |
@itsspriyansh Thanks. I'll try to look at it tomorrow. |
Done in #27. |
If the
--standalone
flag is used, the tool should not download anything extra which might be related to Nightwatch or testing.The text was updated successfully, but these errors were encountered: