Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: install system-images #57

Merged
merged 7 commits into from
Sep 4, 2024
Merged

feat: install system-images #57

merged 7 commits into from
Sep 4, 2024

Conversation

itsspriyansh
Copy link
Contributor

@itsspriyansh itsspriyansh commented Jul 31, 2024 •
edited
Loading

Description

This PR:

  • Introduces a streamlined way to download system images. Instead of overwhelming users with all options at once, we present an intuitive, step-by-step selection process. Users will start by choosing an API level, then proceed to select the type for that level, and finally pick the architecture. Once all selections are made, the download will begin automatically. This user-friendly approach ensures a smooth and efficient experience.
  • Adds a new spawnCommandSync to install system images. This is done to show the installation progress bar to the user. The logic is put in utils/sdk.ts since it will be common function for both installing system images and running dot commands.
Screencast.from.04-09-24.07.05.07.PM.IST.webm

@itsspriyansh
Copy link
Contributor Author

PR #56 adds the index.ts file from which we will call the script in this PR. Once both these PRs are merged then we can add the functionality to call this script.

@itsspriyansh
Copy link
Contributor Author

@garg3133 PR updated.

garg3133
garg3133 reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the "System image already downloaded" statement coming from as shown in the video?

src/commands/android/constants.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/system-image.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/system-image.ts Outdated Show resolved Hide resolved
src/commands/android/utils/sdk.ts Outdated Show resolved Hide resolved
@itsspriyansh itsspriyansh mentioned this pull request Sep 4, 2024
Merged
@itsspriyansh
Copy link
Contributor Author

itsspriyansh commented Sep 4, 2024 •
edited
Loading

Where's the "System image already downloaded" statement coming from as shown in the video?

@garg3133 That is older video. Since we are using spawnSync now, we aren't capturing the output anymore. So everytime the command is run (irrespective of system image being previously installed or not) we will get the same output "System image installed successfully!". Does this work or shall we remove the message entirely since we are already showing the CLI output by sdkmanager?

@itsspriyansh
Copy link
Contributor Author

@garg3133 PR updated

@garg3133 garg3133 merged commit 94fcc84 into nightwatchjs:main Sep 4, 2024
2 checks passed
@itsspriyansh itsspriyansh deleted the install-image branch September 4, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garg3133 garg3133 garg3133 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsspriyansh @garg3133