Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchURL should not be hardcoded to 'localhost' #7

Open
tjad opened this issue Sep 25, 2023 · 2 comments
Open

launchURL should not be hardcoded to 'localhost' #7

tjad opened this issue Sep 25, 2023 · 2 comments

Comments

@tjad
Copy link

tjad commented Sep 25, 2023

The launch url is hardcoded to 'localhost'. I am wanting to do remote testing - via docker. This blocks me from being able to allow my test docker environment from using a custom url to the container hosting the vite server.

this.launchUrl = this.baseUrl = `http://localhost:${vite_port}`;

@ahmad-kashkoush
Copy link

@garg3133 I can Solve this Issue by short circuiting the value assigned to to baseURL, and launchURL variables, may I Solve this Issue?

@ahmad-kashkoush
Copy link

ahmad-kashkoush commented Feb 28, 2024

@garg3133 that is my solution, I'm trying to not make big changes and make everything work as it is

// launchUrl2 is a parameter with empty string default value
  this.launchUrl = this.baseUrl = launchUrl2 ||`http://localhost:${vite_port}`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants