Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog #14

Open
jletey opened this issue Feb 19, 2019 · 11 comments
Open

Add a changelog #14

jletey opened this issue Feb 19, 2019 · 11 comments

Comments

@jletey
Copy link
Contributor

jletey commented Feb 19, 2019

No description provided.

@nikitavoloboev
Copy link
Owner

I've been thinking of incorporating use of generated changelogs for all my projects.

This https://github.com/yoshuawuyts/changelog seems like an awesome tool. Maybe we use that?

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

Nice! Are we ready for a version 1.0.0 release?

@nikitavoloboev
Copy link
Owner

I think so yeah

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

Great ... I'll make a pull request adding a changelog generated using the above mentioned CLI tool

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

@nikitavoloboev I'm getting an error:

shot 2019-02-20 at 13 48 34

Do you know what is wrong?

@nikitavoloboev
Copy link
Owner

I have a feeling it's due to us not tagging a release in Git. I think the tool uses that to make the changelog.

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

I see ... how exactly do you make a git version tag? Also, I'm pretty sure that I can't make the tag ... you'll probably have to do it

@nikitavoloboev
Copy link
Owner

Will take a look in a bit

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

Thank you!

@jletey
Copy link
Contributor Author

jletey commented Feb 20, 2019

Any luck?

@jletey
Copy link
Contributor Author

jletey commented Feb 25, 2019

It turns out that you can't create a changelog without details in a Cargo.toml ... I've submitted a feature request (yoshuawuyts/changelog#25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants