Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI option to automatically replace Google Maps API key with provided key #45

Closed
dharb opened this issue Mar 11, 2021 · 2 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs Feel free to work on this if you want

Comments

@dharb
Copy link

dharb commented Mar 11, 2021

First of all, this is a really excellent tool you've built and I want to say thank you.

Feature request:
It's not always obvious that an app uses Google Maps without first using the app. This leads to some repeated work:

  • patch app
  • install app on device
  • test patched app and discover it uses Google Maps
  • uninstall app
  • patch app again using --wait option
  • replace Google Maps API key in manifest
  • install app on device
  • test app again

It would be great if there was a way to pass a Google Maps API key as a CLI option and automatically replace the Google Maps API key in AndroidManifest.xml with this key (if it exists).

@niklashigi
Copy link
Owner

Thanks for the kind words, David! I can definitely see how this feature would be helpful, and it doesn't seem super difficult to implement. I'm pretty occupied with other projects at the moment, so I would definitely welcome a contribution for this.

Here's a couple of pointers if you or someone else decides to pick this up:

I'd be happy to answer any questions!

@niklashigi niklashigi added enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2021
@dharb
Copy link
Author

dharb commented Mar 16, 2021

Thanks for the pointers, that's super helpful. I'm happy to implement, I'll pick this up and make a PR when I get a chance (probably in the next few weeks).

@niklashigi niklashigi added the up for grabs Feel free to work on this if you want label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs Feel free to work on this if you want
Projects
None yet
Development

No branches or pull requests

2 participants