Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gbasf2 --new downloads if proxy group is not belle. #200

Open
meliache opened this issue Apr 17, 2023 · 0 comments
Open

Use gbasf2 --new downloads if proxy group is not belle. #200

meliache opened this issue Apr 17, 2023 · 0 comments
Labels
enhancement New feature or request gbasf2 Concerns the gbasf2/grid b2luigi wrapper help wanted Extra attention is needed

Comments

@meliache
Copy link
Collaborator

In #197 an issue was discovered that gbasf2 downloads with the --new download the files into a different directory as what is expected by gbasf2 if the proxy group is not belle. @MarcelHoh hotfixed this by removing the --new flag for gbasf2 downloads. This is not an ideal solution, as the --new downloads are much faster and I assume might also become the default in some future.

Therefore, a nice enhancement would be a enhanced download code which handles both cases with the new download method. It would be ideal to simplify the code as much as possible and have as little edge-case handling as possible...
@meliache meliache added enhancement New feature or request help wanted Extra attention is needed gbasf2 Concerns the gbasf2/grid b2luigi wrapper labels Apr 17, 2023
@meliache meliache mentioned this issue Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request gbasf2 Concerns the gbasf2/grid b2luigi wrapper help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meliache