-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't set an environment variable in a task #10851
Comments
putEnv isn't implemented in nimble's VM. https://github.com/nim-lang/nimble/blob/master/src/nimblepkg/nimscriptsupport.nim I had originally authored a PR for this. My current idea is to remove the VM altogether and run nimble scripts through Nim. It is still TBD. |
If it helps to motivate you, I'm really looking forward to this! :-) |
@genotrance I'm still skeptical about the performance of this. Sure, you can cache it but the performance will still be horrible when installing packages as most of them are going to be new. This won't be a problem for now when we don't have a lot of packages but in the future it'll become a massive scalability problem. I would personally much rather push the nimscript evaluation to the Nim binary, this would free Nimble of this horrible dependency, which would have a number of advantages:
|
This has been fixed in Nimble and works as expected now. |
I don't seem to be able to set an environment variable in a nimble task, am I missing something?
Doing
nimble t
outputs:The text was updated successfully, but these errors were encountered: