Regression of tuple type inference when `@[]` is used. #23199

saffage · 2024-01-11T21:41:28Z

Description

This code crashes the compiler with AssertionDefect.

proc doNothingWith[T](x: T): T = x

let x = doNothingWith((@[], 1))

Of course, everything works when the type is specified explicitly. Works on Nim 1.6.18 as expected.

Nim Version

Nim Compiler Version 2.1.1 [Windows: amd64]
Compiled at 2024-01-11
Copyright (c) 2006-2024 by Andreas Rumpf

git hash: 30cb682
active boot switches: -d:release

Nim Compiler Version 2.0.0 [Windows: amd64]
Compiled at 2023-08-01
Copyright (c) 2006-2023 by Andreas Rumpf

active boot switches: -d:release

Current Output

Error: unhandled exception: liftdestructors.nim(633, 5) `t.destructor != nil` [AssertionDefect]

Expected Output

Error: cannot infer the type of the tuple

Possible Solution

No response

Additional Information

No response

The text was updated successfully, but these errors were encountered:

metagn · 2024-01-11T23:13:34Z

Very likely doNothingWith[(seq[empty], int)] used to compile and assigning it to x gave the correct error message. Hence this also used to crash the compiler:

proc doNothingWith[T](x: T): T = x
echo doNothingWith((@[], 1))

We can probably add a hasEmpty check to the new finishOperand.

ringabout · 2024-01-12T12:04:45Z

!nim c

proc doNothingWith[T](x: T): T = x

let x = doNothingWith((@[], 1))

github-actions · 2024-01-12T12:05:30Z

🐧 Linux bisect by @ringabout (member)

devel 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
assertions.nim(34)       raiseAssert
Error: unhandled exception: liftdestructors.nim(633, 5) `t.destructor != nil`  [AssertionDefect]

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:15
Finished 2024-01-12T12:05:15
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkTupleConstr.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

stable 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
assertions.nim(34)       raiseAssert
Error: unhandled exception: liftdestructors.nim(601, 5) `t.destructor != nil`  [AssertionDefect]

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:16
Finished 2024-01-12T12:05:16
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkTupleConstr.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

2.0.0 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
assertions.nim(34)       raiseAssert
Error: unhandled exception: liftdestructors.nim(602, 5) `t.destructor != nil`  [AssertionDefect]

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:19
Finished 2024-01-12T12:05:20
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkTupleConstr.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

1.6.14 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(2, 22) Error: cannot infer the type of the tuple
fatal.nim(54)            sysFatal
Error: unhandled exception: options.nim(645, 14) `false` errGenerated [AssertionDefect]

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:22
Finished 2024-01-12T12:05:22
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkTupleConstr.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

1.4.8 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(2, 22) Error: cannot infer the type of the tuple

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:25
Finished 2024-01-12T12:05:25
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkPar.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

1.2.18 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(2, 22) Error: cannot infer the type of the tuple

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:27
Finished 2024-01-12T12:05:27
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkPar.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

1.0.10 👎 FAIL

Output

Error: Command failed: nim c --run  -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim
/home/runner/work/Nim/Nim/temp.nim(2, 22) Error: cannot infer the type of the tuple

IR

Compiled filesize 0 bytes (0 bytes)

Stats

Started 2024-01-12T12:05:29
Finished 2024-01-12T12:05:29
Duration

AST

nnkStmtList.newTree(
  nnkProcDef.newTree(
    newIdentNode("doNothingWith"),
    newEmptyNode(),
    nnkGenericParams.newTree(
      nnkIdentDefs.newTree(
        newIdentNode("T"),
        newEmptyNode(),
        newEmptyNode()
      )
    ),
    nnkFormalParams.newTree(
      newIdentNode("T"),
      nnkIdentDefs.newTree(
        newIdentNode("x"),
        newIdentNode("T"),
        newEmptyNode()
      )
    ),
    newEmptyNode(),
    newEmptyNode(),
    nnkStmtList.newTree(
      newIdentNode("x")
    )
  ),
  nnkLetSection.newTree(
    nnkIdentDefs.newTree(
      newIdentNode("x"),
      newEmptyNode(),
      nnkCall.newTree(
        newIdentNode("doNothingWith"),
        nnkPar.newTree(
          nnkPrefix.newTree(
            newIdentNode("@"),
            nnkBracket.newTree(
            )
          ),
          newLit(1)
        )
      )
    )
  )
)

Stats

GCC 11.4.0
Clang 14.0.0
NodeJS 19.0
Created 2024-01-12T12:04:45Z
Comments 2
Commands nim c --run -d:nimDebug -d:nimDebugDlOpen -d:ssl -d:nimDisableCertificateValidation --forceBuild:on --colors:off --verbosity:0 --hints:off --lineTrace:off --nimcache:/home/runner/work/Nim/Nim --out:/home/runner/work/Nim/Nim/temp /home/runner/work/Nim/Nim/temp.nim

🤖 Bug found in 17 minutes bisecting 7 commits at 0 commits per second

metagn added Compiler Crash Error Messages labels Jan 11, 2024

ringabout self-assigned this Jan 12, 2024

metagn mentioned this issue Nov 1, 2024

test disabling generic matches to empty containers except @[] #24397

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regression of tuple type inference when `@[]` is used. #23199

Regression of tuple type inference when `@[]` is used. #23199

saffage commented Jan 11, 2024

metagn commented Jan 11, 2024 •

edited

Loading

ringabout commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Regression of tuple type inference when @[] is used. #23199

Regression of tuple type inference when @[] is used. #23199

Comments

saffage commented Jan 11, 2024

Description

Nim Version

Current Output

Expected Output

Possible Solution

Additional Information

metagn commented Jan 11, 2024 • edited Loading

ringabout commented Jan 12, 2024

github-actions bot commented Jan 12, 2024

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Output

IR

Stats

AST

Regression of tuple type inference when `@[]` is used. #23199

Regression of tuple type inference when `@[]` is used. #23199

metagn commented Jan 11, 2024 •

edited

Loading