Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate asyncftpclient #186

Closed
metagn opened this issue Jan 28, 2020 · 2 comments
Closed

Deprecate asyncftpclient #186

metagn opened this issue Jan 28, 2020 · 2 comments

Comments

@metagn
Copy link
Contributor

metagn commented Jan 28, 2020

No public project on GitHub uses asyncftpclient except forks of Nim, my project and https://github.com/nim-lang/nimbuild which hasn't been updated since 2015. More bugs pop up by the second, for example there was this bad one and another one I just found, the store() proc takes a string filename as an argument and doesn't close the file. If I have to PR to Nim itself to fix this and update Nim instead of a single package it doesn't really seem convenient. Right now I just have a copy of the module in my own source.

Original author of this module was @dom96, if that helps things go quicker

@dom96
Copy link
Contributor

dom96 commented Jan 28, 2020

You can't move it or remove it, it's part of 1.0. Best you can do is deprecate it.

@metagn metagn changed the title Move asyncftpclient to its own nimble package or just remove it Deprecate asyncftpclient Jan 29, 2020
@Araq
Copy link
Member

Araq commented Jan 30, 2020

There is more cruft in the stdlib we need to get rid of. However, if nobody uses it, nobody has problems with its bugs either. :P

@metagn metagn closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants