Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --nilseqs:on + associated logic to support it #293

Closed
timotheecour opened this issue Dec 2, 2020 · 1 comment · Fixed by nim-lang/Nim#17211
Closed

remove --nilseqs:on + associated logic to support it #293

timotheecour opened this issue Dec 2, 2020 · 1 comment · Fixed by nim-lang/Nim#17211

Comments

@timotheecour
Copy link
Member

timotheecour commented Dec 2, 2020

rationale

  • this would simplify a lot of code, eg:
rg -i nilseqs | wc -l
      49
  • nim --useVersion only supports nim >= 1.0
  • nim bootstrap currently uses 0.20 and builds fine without --nilseqs:on
  • the only thing that stands in the way are tests for nim in action (see testNimInAction), but IMO this isn't a viable reason to prevent cleaning up nim and reduce complexity; those tests should be updated to use what's in current nim (since even before 1.0), not what was used at the time the book was written

(tests/cpp/tasync_cpp.nim uses --nilseqs:on but doesn't need to, it works without it as jester has been patched a while ago IIRC)

@juancarlospaco
Copy link
Contributor

I do not understand why a compiler needs a book in the sources. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants