Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid unnecessary copy in setXLen #36

Closed
pietroppeter opened this issue May 19, 2021 · 1 comment
Closed

avoid unnecessary copy in setXLen #36

pietroppeter opened this issue May 19, 2021 · 1 comment

Comments

@pietroppeter
Copy link
Contributor

the fix for #27 done in #35 introduced a copy in setXLen that has some impact in the performance in some cases (see benchmark on chainAddition in this comment).
In principle it is possible to fix the issue in self addition without introducing a new copy but it requires more effort.

Note that legacy usage of setXLen remains accessible through a compile time switch bigintsLegacySetXLen.

@pietroppeter
Copy link
Contributor Author

not relevant anymore given the recent merge (#40).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant