Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting deprecated message fornim.provider lsp in project settings (vsCode) #24

Open
FullValueRider opened this issue Dec 14, 2023 · 3 comments

Comments

@FullValueRider
Copy link

FullValueRider commented Dec 14, 2023

I'm trying to follow the saem instructions for the nim language server but I'm seeing this in the project settings
image

Should I just wait or is this an issue?

@nickysn
Copy link
Collaborator

nickysn commented Dec 14, 2023

This extension defaults to using the "lsp" extension, so you don't need this setting at all if you want to use the Nim language server. In a future version, this setting is planned to be removed, hence the deprecation is correct. The problem is that the message "Please use the lsp backend." is confusing and should be changed to something that explains this better. Maybe something like "Provider selection is planned to be removed in the future. Only the lsp backend will be supported. If you're already using the lsp backend, you don't need this setting, since this is now the default."

@nickysn
Copy link
Collaborator

nickysn commented Dec 14, 2023

(any suggestions how to improve the deprecation message are welcome)

@FullValueRider
Copy link
Author

FullValueRider commented Dec 15, 2023

First thing would be to modify the link that leads to references to using the lsp using nim. provider.
If you follow the link named 'here' in the Code Completion section you will see that it leads to a discussion in which nim.provider is set. This discussion is now misleading.

For the depracated message, if it is possible the message should be modified to clarify that the setting has been internalised . e.e rather than 'please use the Lsp backend', how about 'The nim.provider setting has been internalised in the VScode extension (Link?) and uses Lsp as the default setting. It may be safely removed from your config.'

Apologies for the duplicate postings. I was lost in a maze of repositories, all alike......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants