Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove schema.rb from .gitattributes linguist-generated #459

Closed
malparty opened this issue Aug 25, 2023 · 0 comments · Fixed by #468
Closed

Remove schema.rb from .gitattributes linguist-generated #459

malparty opened this issue Aug 25, 2023 · 0 comments · Fixed by #468
Assignees
@malparty
Labels
type : feature
Milestone
5.9.0

Comments

@malparty
Copy link
Member

Why

There is not a single time that my teammates and I don't review this file in the PR.
In deed,

  • if a migration file was updated but the schema was not updated, this can result in issues.
  • if the PR assignee ran the app on another PR (with migrations) and came back to its PR, this can include unwanted changes in the schema.rb file, again, prone to deployment errors or bugs

image

Who Benefits?

Code reviewers who will have 1 click less to perform.
@malparty malparty added this to the 5.8.0 milestone Aug 25, 2023
@malparty malparty self-assigned this Aug 25, 2023
@malparty malparty changed the title Remove Remove schema.rb from auto-hidden file changes Aug 25, 2023
@malparty malparty changed the title Remove schema.rb from auto-hidden file changes Remove schema.rb from .gitattributes linguist-generated Aug 25, 2023
@malparty malparty modified the milestones: 5.8.0, 5.9.0 Sep 14, 2023
@malparty malparty mentioned this issue Sep 14, 2023
Merged
@malparty malparty mentioned this issue Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malparty malparty

Labels
type : feature
Projects
None yet
Milestone
5.9.0
Development

Successfully merging a pull request may close this issue.

[#459] Remove schema.rb from .gitattributes linguist-generated nimblehq/rails-templates
1 participant
@malparty