Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Client: take signing key from node config when creating a validator #3225

Closed
styppo opened this issue Jan 7, 2025 · 3 comments · Fixed by #3226
Closed

RPC Client: take signing key from node config when creating a validator #3225

styppo opened this issue Jan 7, 2025 · 3 comments · Fixed by #3226
Labels
enhancement New feature or request
Milestone

Comments

@styppo
Copy link
Member

styppo commented Jan 7, 2025

Use configured signing key when creating a CreateValidator transaction with the RPC client instead of passing the signing key via RPC.

@styppo styppo added this to the Next release milestone Jan 7, 2025
@styppo styppo added the enhancement New feature or request label Jan 7, 2025
@styppo styppo mentioned this issue Jan 7, 2025
@sisou
Copy link
Member

sisou commented Jan 7, 2025

It should be possible to create such a transaction on another server, too though, no? On one which doesn't have the key configured.

@sisou
Copy link
Member

sisou commented Jan 7, 2025

The parameter could be made optional and fall back to any configured key, or return an error if not configured.

@sisou sisou changed the title RPC: take signing key from node config when creating a validator RPC Client: take signing key from node config when creating a validator Jan 7, 2025
@sisou
Copy link
Member

sisou commented Jan 7, 2025

I updated the title and description to clarify that this is about the RPC client subcommands, not about the server API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants