Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.incbin pseudo op not supported on OS X #2

Closed
pdhborges opened this issue Feb 7, 2011 · 5 comments
Closed

.incbin pseudo op not supported on OS X #2

pdhborges opened this issue Feb 7, 2011 · 5 comments

Comments

@pdhborges
Copy link

ninja.cc uses the .incbin pseudo op which was included in gas since version 2.12. Apple's last included gas version is 1.38 so the file won't assemble.

If you want to use ninja, delete references for the browse command.

@dchest
Copy link

dchest commented Feb 7, 2011

"browse" won't work on Mac anyway, because there's use of /proc/ filesystem when calling Python: "/proc/self/fd/3".

I'd loved if it was fixed (along with "/proc/cpuinfo")

@evmar
Copy link
Collaborator

evmar commented Mar 6, 2011

I have just pushed a fix for the /proc usage. I'm still mulling over the proper way to do the incbin part.

@dchest
Copy link

dchest commented Mar 6, 2011

Maybe some xxd -i / sed magic during build?

@evmar
Copy link
Collaborator

evmar commented Mar 6, 2011

I considered it when I first wrote this, but I think that makes the build depend on vim. (At least that's where xxd seems to come from on my system.)

I have a local patch that just uses plain sh, but I've hit some sort of bug in ninja itself in using it so I'm attempting to reduce a test case first so I can fix the bug.

@evmar
Copy link
Collaborator

evmar commented Mar 7, 2011

I have pushed a fix that uses a shell script.

maximuska referenced this issue in maximuska/ninja Sep 5, 2013
'restat_mtime' is used to verify if the edge was rebuilt
after the 'newest' of the immediate inputs (see RecomputeOutputDirty()).

Since depfile timestamp is not considered in RecomputeOutputDirty(),
there is no real need to consider it when calculating the 'newest input' mtime.
mayank-ramnani referenced this issue in nyuoss/ninja-shadowdash-nyu Oct 1, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants