Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader doesn't dismiss when there are several windows. #211

Closed
ievgenleichenko opened this issue May 7, 2018 · 1 comment
Closed

Loader doesn't dismiss when there are several windows. #211

ievgenleichenko opened this issue May 7, 2018 · 1 comment

Comments

@ievgenleichenko
Copy link

When, for example, alert controller is displayed in new window right after calling stopAnimating, loader doesn't dismiss, because at the time it tries to do so, keyWindow changed.
Our suggestions are:

  • cycle through all windows and find loader to dismiss
  • store weak reference to the window, displaying the loader
@ninjaprox ninjaprox mentioned this issue Jun 23, 2018
Closed
@rlester rlester mentioned this issue Aug 28, 2018
Merged
@ninjaprox
Copy link
Owner

#230 addresses this issue by checking all windows on dismiss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ievgenleichenko @ninjaprox