Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports #122

Closed
Neustradamus opened this issue May 26, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Neustradamus
Copy link

Describe the bug

Dear @nioc,

Can you add supports of :

  • SCRAM-SHA-1
  • SCRAM-SHA-1-PLUS
  • SCRAM-SHA-256
  • SCRAM-SHA-256-PLUS
  • SCRAM-SHA-512
  • SCRAM-SHA-512-PLUS
  • SCRAM-SHA3-512
  • SCRAM-SHA3-512-PLUS

You can add too:

  • SCRAM-SHA-224
  • SCRAM-SHA-224-PLUS
  • SCRAM-SHA-384
  • SCRAM-SHA-384-PLUS

RFC8600: https://tools.ietf.org/html/rfc8600 (2019-06-21):
"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

https://xmpp.org/extensions/inbox/hash-recommendations.html

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

2FA:

IANA:

Linked to:

Steps to reproduce

Expected behavior

Relevant log

No response

local.js configuration

No response

XMPP-web version

Installation

Docker image

XMPP server(s)

Prosody IM, ejabberd, Tigase XMPP Server, other

Browser(s)

No response

Device(s)

No response

Other information

No response

@Neustradamus Neustradamus added the bug Something isn't working label May 26, 2024
@nioc nioc added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels May 26, 2024
@nioc
Copy link
Owner

nioc commented May 26, 2024

Hello @Neustradamus, unfortunately, I have no idea how to do this... may be you can search (or ask people) in the xmpp.js library used by wep-xmpp.

Otherwise I won't be able to implement this feature.

@Neustradamus
Copy link
Author

@nioc: xmpp.js development has been stopped several years ago and does not support recent SCRAM versions.
Hope that you can look to solve it and to permit to use a better SCRAM for security and to look to add -PLUS variants (TLS Channel Binding).

There is strophejs a better support for example.

SCRAM and JavaScript:

@nioc
Copy link
Owner

nioc commented May 27, 2024

This is a huge project, since the entire application is based on this library... if someone wants to handle it, we'll reopen the ticket...

@nioc nioc closed this as not planned Won't fix, can't repro, duplicate, stale May 27, 2024
@Neustradamus
Copy link
Author

@nioc: With your reaction, I can inform you that an unsolved ticket which is closed, there will have never a solution.

It is important to keep this ticket opens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants