Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency errors stemming from scikit-image+numpy #2351

Closed
oesteban opened this issue Dec 19, 2020 · 6 comments
Closed

Dependency errors stemming from scikit-image+numpy #2351

oesteban opened this issue Dec 19, 2020 · 6 comments
Labels
Milestone

Comments

@oesteban
Copy link
Member

@tsalo has hit the dependency issues we have been seeing in NiWorkflows and SDCFlows lately. Solution in nipreps/sdcflows#158.

@oesteban oesteban added the bug label Dec 19, 2020
@tsalo
Copy link
Collaborator

tsalo commented Feb 10, 2021

I'm a little confused by the issue and the fix. It looks like sdcflows' fix was Python <3.7-specific (i.e., just install numpy with no specific version mentioned if Python 3.7+), while fMRIPrep requires 3.7+, and already requires numpy without a specific version mentioned.

@effigies
Copy link
Member

numpy <1.20; python_version < "3.7" should only be relevant if you're using python setup.py install, rather than pip install, which you shouldn't be doing. Is your situation different?

@tsalo
Copy link
Collaborator

tsalo commented Feb 10, 2021

I haven't tried anything locally- I'm just focused on the test failures in #2349 and #2366.

@effigies
Copy link
Member

Ah, so it's a super-old numpy in the Docker image conflicting with a new scikit-image. I'll try upgrading everything to the latest release that isn't a x.y.0.

@tsalo
Copy link
Collaborator

tsalo commented Feb 10, 2021

Oh... so it's just tied to the Docker. That makes sense. Thanks!

@oesteban oesteban added this to the 20.2.3 milestone Jul 19, 2021
@oesteban
Copy link
Member Author

This should be resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants