Skip to content

Update mypy typeshed of generated google/protobuf protos in python w/ mypy-protobuf output #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nipunn1313 opened this issue Nov 16, 2020 · 1 comment · Fixed by python/typeshed#4785

Comments

@nipunn1313
Copy link
Owner

Example file to update. There are several within the google/protobuf directory
https://github.com/python/typeshed/blob/master/third_party/2and3/google/protobuf/compiler/plugin_pb2.pyi

Currently, it's a smorgasbord of handwritten files and autogenerated-by-a-very-old-version-of-mypy-protobuf files

Ideally, we can check in a script which takes a version of protoc and a version of mypy-protobuf as input and will autogenerate all the necessary files - making this process repeatable.

@nipunn1313
Copy link
Owner Author

This is done! See python/typeshed#4850 and friends. Typeshed has a script which pulls in a version of protoc and a version of mypy-protobuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant