Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make spaCy requirement more explicit #100

Open
thomas-onesourceregulatory opened this issue Jul 28, 2021 · 0 comments
Open

make spaCy requirement more explicit #100

thomas-onesourceregulatory opened this issue Jul 28, 2021 · 0 comments

Comments

@thomas-onesourceregulatory
Copy link

thomas-onesourceregulatory commented Jul 28, 2021

Describe the bug
The requirement for spaCy 2.1.8 should be made more explicit (e.g., in new requirements.txt). Currently, this is only in the benchmarking requirements (e.g., requirements-benchmark.txt).

To Reproduce
Steps to reproduce the behavior:

Install pySBD with Spacy 3+ already installed.

Expected behavior

Installation fails due to conflict with spaCy version.

Additional context

The version of spaCy should be listed in requirements.txt, so that this is caught during initial installation (instead of later on when running the benchmark).

At the very least, this should be mentioned in the README file.

Note: Although a fix for spaCy 3+ has been developed (see pull #97), making the requirements explicit is still important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant