RF+ENH: save_json - indent=2 by default #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_dumps_pretty
had it set to 2save_json
also had 2 set manuallyembed_nifti
has its invocation of json.dumps still set to3
, but when RF: embed_nifti -> embed_dicom_and_nifti_metadata and not invoke it if min_meta #432 is merged, it would just usesave_json
with defaults, thus go to 2Altogether, although it would change formatting for some files, I think we better make formatting more consistent sooner (i.e. now) than later.