Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF+ENH: save_json - indent=2 by default #436

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

yarikoptic
Copy link
Member

@yarikoptic yarikoptic commented Mar 29, 2020

Altogether, although it would change formatting for some files, I think we better make formatting more consistent sooner (i.e. now) than later.

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #436 into master will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   74.92%   74.93%   +0.01%     
==========================================
  Files          35       35              
  Lines        2831     2833       +2     
==========================================
+ Hits         2121     2123       +2     
  Misses        710      710              
Impacted Files Coverage Δ
heudiconv/bids.py 82.97% <66.66%> (ø)
heudiconv/utils.py 90.08% <80.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2c526...095679b. Read the comment docs.

…at_infofile

Since save_json first removes file, we should be ok and no set_readonly(.., False)
should longer be needed
@yarikoptic
Copy link
Member Author

just came to my mind the argument "by dcm2niix uses ..." -- apparently it uses TAB for indentation. I guess we just want to make sure to process all .json we get from dcm2niix (either using min_meta or not)

@yarikoptic
Copy link
Member Author

oh well, I think we better make things consistent within a single release (instead of piece meal in multiple), and since we are anyways inconsistent with dcm2niix (or "consistent" with TAB width set to 2 ;)) -- we better proceed by merging.

@yarikoptic yarikoptic merged commit 5681e0d into nipy:master Apr 15, 2020
@yarikoptic yarikoptic added this to the 0.8.0 milestone Apr 15, 2020
@yarikoptic yarikoptic deleted the rf-indent-2 branch April 30, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant