Syntax Highlighting Issue

[gantonious]

I haven't had enough time to look into the exact issue but I noticed earlier today that Kotlin syntax highlighting isn't working as expected. See the following sample file in linguist: https://github.com/github/linguist/blob/master/samples/Kotlin/Foo.kt

It looks like linguist just had a release earlier today and I think that's when it broke. See github-linguist/linguist#4324.

[Grohden]

It's happening here too

https://github.com/levibostian/Wendy-Android/blob/b93f22b7da53250cb1e78bbbe09129378af0109e/wendy/src/main/java/com/levibostian/wendy/WendyConfig.kt#L89

[gantonious]

Just a quick follow up from yesterday. I quickly spun up a VSCode language extension using the same syntax currently being used by linguist and it seems to be working fine in VSCode (note I just tested the plist file not the YAML):

[nishtahir]

Thanks for reporting this. I started looking into this yesterday and it seems that the bug has something to do with

language-kotlin/syntax/Kotlin.tmLanguage

Line 809 in 7631a67

<dict>

which was to allow for generics in types.

It looks like VSCode and GitHub treat these very differently. After removing it and testing it with lightshow. It seems to work correctly.

I've pushed a fix for it in 69733ef

[Zhuinden]

Is this fix out and available? I'm asking because PRs that I'm reviewing still show up with pretty much all the code ending up in a blue-ish (purple) tint.

[gantonious]

It should be out when github/lingust does another release. See: github-linguist/linguist#4329

[lildude]

GitHub should now be rendering Kotlin files correctly again.

[nishtahir]

Thanks, @lildude!