Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer close und update methods for TextIndexingService #176

Closed
forum-is opened this issue Jun 17, 2019 · 0 comments
Closed

Offer close und update methods for TextIndexingService #176

forum-is opened this issue Jun 17, 2019 · 0 comments
Assignees
Milestone

Comments

@forum-is
Copy link

Proposal

The interface for TextIndexingService should offer a close() method which would be called within db.close(). This would allow a proper shutdown for external fulltext indexers by implementing this method.

Also, an additional update() method would be beneficial to possibly force any internal updates.

Use case

When using Apache Lucene as a third-party fulltext index with a filesystem indexer, forcibly committing changes immediately after updating each field results in very poor performance. Lucene already offers mechanisms that commit changes when either its memory buffer is full (default) and/or a certain threshold of uncommitted documents is present (optional).

However, to ensure that all pending changes are properly persisted, commit() has to be called on shutdown.

The update() method could ensure consistency after bulk updates or could even be called periodically from outside the indexing service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants